Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds CA2007 warning #170

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

leonardochaia
Copy link
Contributor

What this PR does / why we need it

This PR adds severity Warning when ConfigureAwait(false) is not used in an awaited Task.
This is excluded on Tests project.

Which issue(s) this PR resolves / fixes

Fixes #168

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (13b8798) to head (3cfffca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   81.68%   81.70%   +0.01%     
==========================================
  Files          35       35              
  Lines        1103     1104       +1     
  Branches      128      127       -1     
==========================================
+ Hits          901      902       +1     
  Misses        146      146              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

.editorconfig Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Leonardo Chaia <[email protected]>
Signed-off-by: Leonardo Chaia <[email protected]>
@shizhMSFT shizhMSFT merged commit a9103d2 into oras-project:main Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling CA2007 rule to require ConfigureAwait(false) on all awaited tasks
3 participants